mon/OSDMonitor: fix output func name in can_mark_out #14758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Apr 25, 2017
src/mon/OSDMonitor.cc
Outdated
| @@ -1833,11 +1833,11 @@ bool OSDMonitor::can_mark_out(int i) | |||
| float in_ratio = (float)in / (float)num_osds; | |||
| if (in_ratio < g_conf->mon_osd_min_in_ratio) { | |||
| if (i >= 0) | |||
| dout(5) << "can_mark_down current in_ratio " << in_ratio << " < min " | |||
| dout(5) << "can_mark_out current in_ratio " << in_ratio << " < min " | |||
There was a problem hiding this comment.
can we use __func__ here?
There was a problem hiding this comment.
The problem is that we manually output the function name everywhere within this file.
So I perfer to keep pace with others.
But I'll do it if you insist.
There was a problem hiding this comment.
please search for __func__ in this source file for more examples.
There was a problem hiding this comment.
Fixed. @tchaikov Can you look ,again?
xiexingguo
force-pushed
the
fix-can_mark_out-output
branch
from
0817c08
to
ce1b0d1
Compare
use __func__ macro instead. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Apr 27, 2017
|
retest this please |
tchaikov
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn